Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405323

Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is rotated

Show all headers | View raw

Hello.

On 5/23/2016 3:00 PM, Andrew Goodbody wrote:

> Ensure that the endpoint is stopped by clearing REQPKT before
> clearing DATAERR_NAKTIMEOUT before rotating the queue on the
> dedicated bulk endpoint.
> This addresses an issue where a race could result in the endpoint
> receiving data before it was reprogrammed resulting in a warning
> about such data from musb_rx_reinit before it was thrown away.
> The data thrown away was a valid packet that had been correctly
> ACKed which meant the host and device got out of sync.
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody@cambrionix.com>
> Cc: stable@vger.kernel.org
> ---
> V2 added comment about clearing REQPKT before DATAERR_NAKTIMEOUT
>
>  drivers/usb/musb/musb_host.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 2966596..676cb98 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -997,6 +997,12 @@ static void musb_bulk_nak_timeout(struct musb *musb, struct musb_hw_ep *ep,
>  		/* clear nak timeout bit */
>  		rx_csr = musb_readw(epio, MUSB_RXCSR);
>  		rx_csr |= MUSB_RXCSR_H_WZC_BITS;
> +		/*
> +		 * Need to stop the transaction by clearing REQPKT before

    Transcation? Maybe transfer?

> +		 * DATAERR_NAKTIMEOUT ref TRM section 16.3.8.2.2.1.2

    Which TRM? Do you understand that the MUSB core is used by multiple SoCs? 
I'd recommend referring just to the "abstract" manual or the MUSB programmer's 
guide (section 9.2.2 if you want an exact ref.).

[...]

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is rotated Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-05-23 14:10 +0200
  Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is  rotated Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-23 14:40 +0200
    RE: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is  rotated Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-05-23 15:30 +0200
      Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is  rotated Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-23 15:50 +0200
        Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is  rotated Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-23 16:40 +0200
          RE: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is  rotated Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-05-23 17:30 +0200
            Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is  rotated Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-23 18:50 +0200

csiph-web