Re: [PATCH] KVM: Unify traced vector format

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KVM: Unify traced vector format
Date	2016-05-23 14:30 +0200
Message-ID	<rBX9E-5Jd-45@gated-at.bofh.it> (permalink)
References	<rBRQC-2t3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 23/05/2016 08:43, Jan Kiszka wrote:
> Specifically the change from hex to decimal helps correlating events.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  include/trace/events/kvm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index 526fb3d..f28292d 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -108,7 +108,7 @@ TRACE_EVENT(kvm_ioapic_set_irq,
>  		__entry->coalesced	= coalesced;
>  	),
>  
> -	TP_printk("pin %u dst %x vec=%u (%s|%s|%s%s)%s",
> +	TP_printk("pin %u dst %x vec %u (%s|%s|%s%s)%s",
>  		  __entry->pin, (u8)(__entry->e >> 56), (u8)__entry->e,
>  		  __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
>  		  (__entry->e & (1<<11)) ? "logical" : "physical",
> @@ -129,7 +129,7 @@ TRACE_EVENT(kvm_ioapic_delayed_eoi_inj,
>  		__entry->e		= e;
>  	),
>  
> -	TP_printk("dst %x vec=%u (%s|%s|%s%s)",
> +	TP_printk("dst %x vec %u (%s|%s|%s%s)",
>  		  (u8)(__entry->e >> 56), (u8)__entry->e,
>  		  __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
>  		  (__entry->e & (1<<11)) ? "logical" : "physical",
> @@ -151,7 +151,7 @@ TRACE_EVENT(kvm_msi_set_irq,
>  		__entry->data		= data;
>  	),
>  
> -	TP_printk("dst %u vec %x (%s|%s|%s%s)",
> +	TP_printk("dst %u vec %u (%s|%s|%s%s)",
>  		  (u8)(__entry->address >> 12), (u8)__entry->data,
>  		  __print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode),
>  		  (__entry->address & (1<<2)) ? "logical" : "physical",
> 

Looks good, thanks.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: Unify traced vector format Jan Kiszka <jan.kiszka@siemens.com> - 2016-05-23 08:50 +0200
  Re: [PATCH] KVM: Unify traced vector format Paolo Bonzini <pbonzini@redhat.com> - 2016-05-23 14:30 +0200

csiph-web