Re: [patch] sched/fair: Move se->vruntime normalization state into struct sched_entity

From	Mike Galbraith <umgwanakikbuti@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [patch] sched/fair: Move se->vruntime normalization state into struct sched_entity
Date	2016-05-23 12:30 +0200
Message-ID	<rBVhv-4Bg-7@gated-at.bofh.it> (permalink)
References	(3 earlier) <rBkrE-7qE-13@gated-at.bofh.it> <rBvGp-6hJ-1@gated-at.bofh.it> <rBUbM-3YT-19@gated-at.bofh.it> <rBUEN-48A-7@gated-at.bofh.it> <rBV7Q-4y5-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-05-23 at 18:13 +0800, Wanpeng Li wrote:
> 2016-05-23 17:40 GMT+08:00 Mike Galbraith <umgwanakikbuti@gmail.com>:
> > On Mon, 2016-05-23 at 11:19 +0200, Peter Zijlstra wrote:
> > > On Sun, May 22, 2016 at 09:00:01AM +0200, Mike Galbraith wrote:
> > > > On Sat, 2016-05-21 at 21:00 +0200, Mike Galbraith wrote:
> > > > > On Sat, 2016-05-21 at 16:04 +0200, Mike Galbraith wrote:
> > > > > 
> > > > > > Wakees that were not migrated/normalized eat an unwanted
> > > > > > min_vruntime,
> > > > > > and likely take a size XXL latency hit.  Big box running
> > > > > > master bled
> > > > > > profusely under heavy load until I turned TTWU_QUEUE off.
> > > > 
> > > > May as well make it official and against master.today.  Fly or
> > > > die
> > > > little patchlet.
> > > > 
> > > > sched/fair: Move se->vruntime normalization state into struct
> > > > sched_entity
> > > 
> > > Does this work?
> > 
> > Yup, bugs--.  Kinda funny, I considered ~this way first, but
> > thought
> > you'd not that approach.. dang, got it back-assward ;-)
> > 
> 
> Nicer this one.

Well, the wakeup is a remote wakeup whether the flag is set or not, so
in that regard it's not _squeaky_ clean, but is dinky, works (yay)..
and doesn't invent helpers with funny names vs what they actually do.

	-Mike

Thread

Re: [PATCH 2/3] sched,fair: Fix local starvation Mike Galbraith <mgalbraith@suse.de> - 2016-05-21 16:10 +0200
  Re: [PATCH 2/3] sched,fair: Fix local starvation Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-05-21 21:10 +0200
    [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-05-22 09:10 +0200
      Re: [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Peter Zijlstra <peterz@infradead.org> - 2016-05-22 11:40 +0200
        Re: [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-05-22 12:00 +0200
        Re: [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Peter Zijlstra <peterz@infradead.org> - 2016-05-22 12:40 +0200
      Re: [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Peter Zijlstra <peterz@infradead.org> - 2016-05-23 11:20 +0200
        Re: [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-05-23 11:50 +0200
          Re: [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Wanpeng Li <kernellwp@gmail.com> - 2016-05-23 12:20 +0200
            Re: [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-05-23 12:30 +0200
          Re: [patch] sched/fair: Move se->vruntime normalization state into  struct sched_entity Peter Zijlstra <peterz@infradead.org> - 2016-05-23 14:30 +0200
        [tip:sched/urgent] sched/core: Fix remote wakeups tip-bot for Peter Zijlstra <tipbot@zytor.com> - 2016-05-25 09:20 +0200
  Re: [PATCH 2/3] sched,fair: Fix local starvation Wanpeng Li <kernellwp@gmail.com> - 2016-05-22 09:00 +0200
    Re: [PATCH 2/3] sched,fair: Fix local starvation Mike Galbraith <mgalbraith@suse.de> - 2016-05-22 09:20 +0200
      Re: [PATCH 2/3] sched,fair: Fix local starvation Wanpeng Li <kernellwp@gmail.com> - 2016-05-22 09:30 +0200
        Re: [PATCH 2/3] sched,fair: Fix local starvation Mike Galbraith <mgalbraith@suse.de> - 2016-05-22 09:40 +0200
          Re: [PATCH 2/3] sched,fair: Fix local starvation Wanpeng Li <kernellwp@gmail.com> - 2016-05-22 09:50 +0200
            Re: [PATCH 2/3] sched,fair: Fix local starvation Mike Galbraith <mgalbraith@suse.de> - 2016-05-22 10:10 +0200
              Re: [PATCH 2/3] sched,fair: Fix local starvation Wanpeng Li <kernellwp@gmail.com> - 2016-05-22 10:30 +0200
                Re: [PATCH 2/3] sched,fair: Fix local starvation Mike Galbraith <mgalbraith@suse.de> - 2016-05-22 10:40 +0200
                Re: [PATCH 2/3] sched,fair: Fix local starvation Wanpeng Li <kernellwp@gmail.com> - 2016-05-22 11:00 +0200

csiph-web