Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1405239

Re: [PATCH 7/8] pipe: account to kmemcg

From Vladimir Davydov <vdavydov@virtuozzo.com>
Newsgroups linux.kernel
Subject Re: [PATCH 7/8] pipe: account to kmemcg
Date 2016-05-23 13:00 +0200
Message-ID <rBVKy-4Lf-13@gated-at.bofh.it> (permalink)
References <rBVAR-4HP-5@gated-at.bofh.it> <rBVAR-4HP-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, May 23, 2016 at 06:39:40PM +0800, kbuild test robot wrote:
...
>    fs/built-in.o: In function `anon_pipe_buf_steal':
> >> pipe.c:(.text+0x5f8d): undefined reference to `memcg_kmem_uncharge'

From: Vladimir Davydov <vdavydov@virtuozzo.com>
Subject: [PATCH] pipe-account-to-kmemcg-fix


diff --git a/fs/pipe.c b/fs/pipe.c
index 6345f3543788..b3ad0b33f04e 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -144,8 +144,10 @@ static int anon_pipe_buf_steal(struct pipe_inode_info *pipe,
 	struct page *page = buf->page;
 
 	if (page_count(page) == 1) {
-		memcg_kmem_uncharge(page, 0);
-		__ClearPageKmemcg(page);
+		if (memcg_kmem_enabled()) {
+			memcg_kmem_uncharge(page, 0);
+			__ClearPageKmemcg(page);
+		}
 		__SetPageLocked(page);
 		return 0;
 	}

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 7/8] pipe: account to kmemcg kbuild test robot <lkp@intel.com> - 2016-05-23 12:50 +0200
  Re: [PATCH 7/8] pipe: account to kmemcg Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-05-23 13:00 +0200
    Re: [PATCH 7/8] pipe: account to kmemcg Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-05-23 14:20 +0200

csiph-web