Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405199

Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings

Show all headers | View raw

Hi, YT:

One comment below.

On Fri, 2016-05-20 at 23:05 +0800, yt.shen@mediatek.com wrote:
> From: YT Shen <yt.shen@mediatek.com>
> 
> There are some hardware settings changed, between MT8173 & MT2701:
> DISP_OVL address offset changed, color format definition changed.
> DISP_RDMA fifo size changed.
> DISP_COLOR offset changed.
> 
> Signed-off-by: YT Shen <yt.shen@mediatek.com>
> ---
> +
> +static inline struct mtk_ddp_comp_driver_data *mtk_ovl_get_driver_data(
> +	struct platform_device *pdev)
> +{
> +	const struct of_device_id *of_id =
> +		of_match_device(mtk_disp_ovl_driver_dt_match, &pdev->dev);
> +
> +	return (struct mtk_ddp_comp_driver_data *)of_id->data;
> +}
> +
> +static inline struct mtk_ddp_comp_driver_data *mtk_rdma_get_driver_data(
> +	struct platform_device *pdev)
> +{
> +	const struct of_device_id *of_id =
> +		of_match_device(mtk_disp_rdma_driver_dt_match, &pdev->dev);
> +
> +	return (struct mtk_ddp_comp_driver_data *)of_id->data;
> +}
> +
> +static inline struct mtk_ddp_comp_driver_data *mtk_color_get_driver_data(
> +	struct device_node *node)
> +{
> +	const struct of_device_id *of_id =
> +		of_match_node(mtk_disp_color_driver_dt_match, node);
> +
> +	return (struct mtk_ddp_comp_driver_data *)of_id->data;
> +}
> + 

These three functions looks the same with different parameter:
mtk_disp_ovl_driver_dt_match, mtk_disp_rdma_driver_dt_match, and
mtk_disp_color_driver_dt_match. So merge them to prevent duplicated
code.

Regards,
CK

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC v2 0/5] MT2701 DRM support <yt.shen@mediatek.com> - 2016-05-20 17:10 +0200
  [RFC v2 4/5] drm/mediatek: add shadow register support <yt.shen@mediatek.com> - 2016-05-20 17:10 +0200
  [RFC v2 5/5] arm: dts: mt2701: Add display subsystem related nodes for MT2701 <yt.shen@mediatek.com> - 2016-05-20 17:10 +0200
  [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings <yt.shen@mediatek.com> - 2016-05-20 17:10 +0200
    Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different  hardware settings CK Hu <ck.hu@mediatek.com> - 2016-05-23 11:50 +0200
      Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different  hardware settings YT Shen <yt.shen@mediatek.com> - 2016-05-27 09:40 +0200
        Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different  hardware settings Emil Velikov <emil.l.velikov@gmail.com> - 2016-05-27 11:30 +0200
          Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different  hardware settings YT Shen <yt.shen@mediatek.com> - 2016-05-30 12:30 +0200
      Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different  hardware settings Thierry Reding <thierry.reding@gmail.com> - 2016-05-30 12:50 +0200

csiph-web