[PATCH] mm: compact: remove watermark check at compact suitable

From	Chen Feng <puck.chen@hisilicon.com>
Newsgroups	linux.kernel
Subject	[PATCH] mm: compact: remove watermark check at compact suitable
Date	2016-05-23 05:30 +0200
Message-ID	<rBOJ3-Fj-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There are two paths calling this function.
For direct compact, there is no need to check the zone watermark here.
For kswapd wakeup kcompactd, since there is a reclaim before this.
It makes sense to do compact even the watermark is ok at this time.

Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
---
 mm/compaction.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 8fa2540..cb322df 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1260,13 +1260,6 @@ static unsigned long __compaction_suitable(struct zone *zone, int order,
 		return COMPACT_CONTINUE;
 
 	watermark = low_wmark_pages(zone);
-	/*
-	 * If watermarks for high-order allocation are already met, there
-	 * should be no need for compaction at all.
-	 */
-	if (zone_watermark_ok(zone, order, watermark, classzone_idx,
-								alloc_flags))
-		return COMPACT_PARTIAL;
 
 	/*
 	 * Watermarks for order-0 must be met for compaction. Note the 2UL.
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: compact: remove watermark check at compact suitable Chen Feng <puck.chen@hisilicon.com> - 2016-05-23 05:30 +0200
  Re: [PATCH] mm: compact: remove watermark check at compact suitable Vlastimil Babka <vbabka@suse.cz> - 2016-05-23 10:30 +0200

csiph-web