Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1404769

Re: [PATCH net V2] tuntap: correctly wake up process during uninit

Show all headers | View raw

From: Jason Wang <jasowang@redhat.com>
Date: Thu, 19 May 2016 13:36:51 +0800

> We used to check dev->reg_state against NETREG_REGISTERED after each
> time we are woke up. But after commit 9e641bdcfa4e ("net-tun:
> restructure tun_do_read for better sleep/wakeup efficiency"), it uses
> skb_recv_datagram() which does not check dev->reg_state. This will
> result if we delete a tun/tap device after a process is blocked in the
> reading. The device will wait for the reference count which was held
> by that process for ever.
> 
> Fixes this by using RCV_SHUTDOWN which will be checked during
> sk_recv_datagram() before trying to wake up the process during uninit.
> 
> Fixes: 9e641bdcfa4e ("net-tun: restructure tun_do_read for better
> sleep/wakeup efficiency")
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Xi Wang <xii@google.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> - The patch is needed for -stable.
> - Changes from v1: remove unnecessary NETREG_REGISTERED check in tun_do_read()

Applied and queued up for -stable.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net V2] tuntap: correctly wake up process during uninit Jason Wang <jasowang@redhat.com> - 2016-05-19 07:40 +0200
  Re: [PATCH net V2] tuntap: correctly wake up process during uninit Eric Dumazet <eric.dumazet@gmail.com> - 2016-05-19 13:30 +0200
  Re: [PATCH net V2] tuntap: correctly wake up process during uninit "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-19 14:00 +0200
  Re: [PATCH net V2] tuntap: correctly wake up process during uninit David Miller <davem@davemloft.net> - 2016-05-21 01:40 +0200

csiph-web