Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner field

From	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner field
Date	2016-05-19 15:50 +0200
Message-ID	<rAwuR-si-11@gated-at.bofh.it> (permalink)
References	(5 earlier) <rzSH8-aP-19@gated-at.bofh.it> <rzTa9-mb-7@gated-at.bofh.it> <rA7wt-1ja-1@gated-at.bofh.it> <rAdsj-54h-5@gated-at.bofh.it> <rAs7U-6aN-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 19, 2016 at 11:00:13AM +0200, Peter Zijlstra wrote:
> On Wed, May 18, 2016 at 10:26:06AM -0700, Paul E. McKenney wrote:
> > On Wed, May 18, 2016 at 01:05:55PM +0200, Peter Zijlstra wrote:
> 
> > > Alternatively, could we try and talk to our GCC friends to make sure GCC
> > > doesn't tear loads/stores irrespective of what the C language spec
> > > allows?
> > 
> > Interestingly enough, they used to make that guarantee, but removed it
> > when C11 showed up.
> 
> Did someone tell them this was a regression and have them fix it? They
> can't just change things like this.

I did, informally.  I was told that the atomics were to replace them.
I have been bugging them about volatile ever since, given that some
people would dearly like to eliminate volatile from the language.  (I
believe I am making good progress on preventing this, with a lot of help
more recently.)

> > Me, I would feel better explicitly telling the compiler what I needed.
> > It is all too easy for bugs to slip in otherwise, especially when the
> > gcc guys are adding exciting new optimizations.
> 
> GCC guys (as opposed to the language guys) should be far more amenable
> to our needs, and I don't think they want to break the kernel any more
> than we do.

Some are, some aren't.  We should of course cherish the ones who would
like to avoid breaking the kernel.

							Thanx, Paul

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Zijlstra <peterz@infradead.org> - 2016-05-13 17:10 +0200
  Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Hurley <peter@hurleysoftware.com> - 2016-05-13 20:00 +0200
    Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Zijlstra <peterz@infradead.org> - 2016-05-16 13:20 +0200
      Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-05-16 14:20 +0200
        Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Hurley <peter@hurleysoftware.com> - 2016-05-16 16:20 +0200
          Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-05-16 19:30 +0200
            Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Hurley <peter@hurleysoftware.com> - 2016-05-17 21:50 +0200
              Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Hurley <peter@hurleysoftware.com> - 2016-05-17 22:00 +0200
          Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Zijlstra <peterz@infradead.org> - 2016-05-16 20:00 +0200
            Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Hurley <peter@hurleysoftware.com> - 2016-05-17 21:20 +0200
              Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-05-17 21:50 +0200
                Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Zijlstra <peterz@infradead.org> - 2016-05-18 13:10 +0200
                Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Waiman Long <waiman.long@hpe.com> - 2016-05-18 18:00 +0200
                Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-05-18 19:30 +0200
                Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-05-18 19:30 +0200
                Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field Peter Zijlstra <peterz@infradead.org> - 2016-05-19 11:10 +0200
                Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner  field "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-05-19 15:50 +0200

csiph-web