[PATCH] net: usb: ch9200: use kmemdup

From	Muhammad Falak R Wani <falakreyaz@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] net: usb: ch9200: use kmemdup
Date	2016-05-19 16:00 +0200
Message-ID	<rAwEy-vI-31@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
 drivers/net/usb/ch9200.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/usb/ch9200.c b/drivers/net/usb/ch9200.c
index 5e151e6..8a40202 100644
--- a/drivers/net/usb/ch9200.c
+++ b/drivers/net/usb/ch9200.c
@@ -155,12 +155,11 @@ static int control_write(struct usbnet *dev, unsigned char request,
 		   index, size);
 
 	if (data) {
-		buf = kmalloc(size, GFP_KERNEL);
+		buf = kmemdup(data, size, GFP_KERNEL);
 		if (!buf) {
 			err = -ENOMEM;
 			goto err_out;
 		}
-		memcpy(buf, data, size);
 	}
 
 	err = usb_control_msg(dev->udev,
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: usb: ch9200: use kmemdup Muhammad Falak R Wani <falakreyaz@gmail.com> - 2016-05-19 16:00 +0200
  Re: [PATCH] net: usb: ch9200: use kmemdup David Miller <davem@davemloft.net> - 2016-05-21 02:00 +0200

csiph-web