Re: [PATCH v1] PM / sleep: make pm notifier called symmetrically

From	Lianwei Wang <lianwei.wang@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] PM / sleep: make pm notifier called symmetrically
Date	2016-05-19 08:10 +0200
Message-ID	<rApjH-4s7-3@gated-at.bofh.it> (permalink)
References	<rA2Qa-6EU-7@gated-at.bofh.it> <rAgq6-6Tl-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 18, 2016 at 1:34 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Wed, May 18, 2016 at 8:07 AM, Lianwei Wang <lianwei.wang@gmail.com> wrote:
>> This makes pm notifier PREPARE/POST symmetrical: if PREPARE
>> fails, we will only undo what ever happened on PREPARE.
>>
>> It fixes the unbalanced cpu hotplug enable in cpu pm notifier.
>
> Can you please describe the problem you're trying to address in a bit
> more detail?

It is described in another patch, and it is a common issue. I fixed
the similar issue several times, all because that the CPU_POST_SUSPEND
notifier callback is called without call CPU_SUSPEND_PREPARE notifier
callback before. Something is DO in PM_XXX_PREPARE and UNDO in
POST_XXX. If we don't DO it in XXX_PREPARE then we don't need to UNDO
it in  PM_POST_XXX.

Here is the link for the unbalanced cpu hotplug enable case:
https://lkml.org/lkml/2016/5/6/61 .

Thanks,
Lianwei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] PM / sleep: make pm notifier called symmetrically Lianwei Wang <lianwei.wang@gmail.com> - 2016-05-18 08:10 +0200
  Re: [PATCH v1] PM / sleep: make pm notifier called symmetrically "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-18 22:40 +0200
    Re: [PATCH v1] PM / sleep: make pm notifier called symmetrically Lianwei Wang <lianwei.wang@gmail.com> - 2016-05-19 08:10 +0200

csiph-web