Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1403196

Re: [PATCH] usb: echi-hcd: Add register access check in shutdown

Show all headers | View raw

On 18/05/16 15:56, Alan Stern wrote:
> This doesn't seem like the right place.  What you really should do is
> skip calling ehci_silence_controller() if the hardware isn't
> accessible.  That's where the hardware gets touched, not in
> ehci_shutdown().

Just tried this suggestion, this would not work as well, Its not just 
the hardware registers, which are of concern here, but also the rest of 
the things like ehci->hrtimer pointer which are allocated or initialized 
as part of ehci_setup().

Either the msm controller driver is not correct or we should have a way 
to stop calling ehci_shutdown() if there was no ehci_setup() done yet.

Any suggestions?


--srini

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: echi-hcd: Add register access check in shutdown Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-05-18 16:20 +0200
  Re: [PATCH] usb: echi-hcd: Add register access check in shutdown Alan Stern <stern@rowland.harvard.edu> - 2016-05-18 17:00 +0200
    Re: [PATCH] usb: echi-hcd: Add register access check in shutdown Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-05-18 17:40 +0200
      Re: [PATCH] usb: echi-hcd: Add register access check in shutdown Alan Stern <stern@rowland.harvard.edu> - 2016-05-18 18:20 +0200
        Re: [PATCH] usb: echi-hcd: Add register access check in shutdown Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-05-18 19:10 +0200
    Re: [PATCH] usb: echi-hcd: Add register access check in shutdown Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-05-18 20:00 +0200
      Re: [PATCH] usb: echi-hcd: Add register access check in shutdown Alan Stern <stern@rowland.harvard.edu> - 2016-05-18 21:00 +0200

csiph-web