Re: [PATCH] remove unused blkdev_dax_capable() function

From	Toshi Kani <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] remove unused blkdev_dax_capable() function
Date	2016-05-18 16:20 +0200
Message-ID	<rAaul-3d5-5@gated-at.bofh.it> (permalink)
References	<rxiRt-6cC-25@gated-at.bofh.it> <rxiRv-6cC-65@gated-at.bofh.it> <rA4yB-7yy-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-05-18 at 09:54 +0200, Arnd Bergmann wrote:
> The change from blkdev_dax_capable() to bdev_dax_capable() removed the
> only user of the former, so we now get a build warning:
> 
> fs/block_dev.c:1244:13: error: 'blkdev_dax_capable' defined but not used
> [-Werror=unused-function]
>  static bool blkdev_dax_capable(struct block_device *bdev)
> 
> This removes the now-unused function.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a8078b1fc616 ("block: Update blkdev_dax_capable() for
> consistency")
 :
> It's not entirely from the patch description what the intention was here
> in keeping two slightly different implementations of the same function
> in one file, my best guess is that it was not intentional and we should
> just remove this.

Thanks for the build fix.  Looks like there was a conflict
between 8044aae6f374 and a8078b1fc616d, which resulted this build error.
Both patches moved blkdev_dax_capable() from block/ioctl.c
to fs/block_dev.c.

Acked-by: Toshi Kani <toshi.kani@hpe.com>

Thanks,
-Toshi

Thread

[PATCH] remove unused blkdev_dax_capable() function Arnd Bergmann <arnd@arndb.de> - 2016-05-18 10:00 +0200
  Re: [PATCH] remove unused blkdev_dax_capable() function Toshi Kani <toshi.kani@hpe.com> - 2016-05-18 16:20 +0200
  Re: [PATCH] remove unused blkdev_dax_capable() function Vishal Verma <vishal.l.verma@intel.com> - 2016-05-18 21:40 +0200

csiph-web