Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1403010

Re: [PATCH v2] mm: check_new_page_bad() directly returns in __PG_HWPOISON case

From Mel Gorman <mgorman@techsingularity.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2] mm: check_new_page_bad() directly returns in __PG_HWPOISON case
Date 2016-05-18 16:10 +0200
Message-ID <rAakG-39y-9@gated-at.bofh.it> (permalink)
References <rzHVo-1FI-31@gated-at.bofh.it> <rA5XI-aM-13@gated-at.bofh.it> <rA67n-eQ-11@gated-at.bofh.it> <rA6K6-JL-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, May 18, 2016 at 10:09:50AM +0000, Naoya Horiguchi wrote:
> From c600b1ee6c36b3df6973f5365b4179c92f3c08e3 Mon Sep 17 00:00:00 2001
> From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Date: Wed, 18 May 2016 18:42:57 +0900
> Subject: [PATCH v2] mm: check_new_page_bad() directly returns in __PG_HWPOISON
>  case
> 
> Currently we check page->flags twice for "HWPoisoned" case of
> check_new_page_bad(), which can cause a race with unpoisoning.
> This race unnecessarily taints kernel with "BUG: Bad page state".
> check_new_page_bad() is the only caller of bad_page() which is interested
> in __PG_HWPOISON, so let's move the hwpoison related code in bad_page()
> to it.
> 
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

Acked-by: Mel Gorman <mgorman@techsingularity.net>

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v1] mm: bad_page() checks bad_flags instead of page->flags for hwpoison page Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-05-17 09:50 +0200
  Re: [PATCH v1] mm: bad_page() checks bad_flags instead of page->flags  for hwpoison page Vlastimil Babka <vbabka@suse.cz> - 2016-05-18 09:40 +0200
  Re: [PATCH v1] mm: bad_page() checks bad_flags instead of  page->flags for hwpoison page Mel Gorman <mgorman@techsingularity.net> - 2016-05-18 11:30 +0200
    Re: [PATCH v1] mm: bad_page() checks bad_flags instead of page->flags  for hwpoison page Vlastimil Babka <vbabka@suse.cz> - 2016-05-18 11:40 +0200
      Re: [PATCH v1] mm: bad_page() checks bad_flags instead of  page->flags for hwpoison page Mel Gorman <mgorman@techsingularity.net> - 2016-05-18 12:00 +0200
        Re: [PATCH v1] mm: bad_page() checks bad_flags instead of  page->flags for hwpoison page Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-05-18 12:20 +0200
      [PATCH v2] mm: check_new_page_bad() directly returns in  __PG_HWPOISON case Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-05-18 12:20 +0200
        Re: [PATCH v2] mm: check_new_page_bad() directly returns in  __PG_HWPOISON case Mel Gorman <mgorman@techsingularity.net> - 2016-05-18 16:10 +0200
          Re: [PATCH v2] mm: check_new_page_bad() directly returns in  __PG_HWPOISON case Vlastimil Babka <vbabka@suse.cz> - 2016-05-20 16:30 +0200

csiph-web