Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1403003
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v12 07/13] task_isolation: add debug boot flag |
| Date | 2016-05-18 16:00 +0200 |
| Message-ID | <rAab0-2Rm-15@gated-at.bofh.it> (permalink) |
| References | <rllrI-6RI-13@gated-at.bofh.it> <rAab0-2Rm-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Apr 05, 2016 at 01:38:36PM -0400, Chris Metcalf wrote:
> +#ifdef CONFIG_TASK_ISOLATION
> +void task_isolation_debug(int cpu)
> +{
> + struct task_struct *p;
> +
> + if (!task_isolation_possible(cpu))
> + return;
> +
> + rcu_read_lock();
> + p = cpu_curr(cpu);
> + get_task_struct(p);
> + rcu_read_unlock();
> + task_isolation_debug_task(cpu, p);
> + put_task_struct(p);
This is still broken...
Also, I really don't like how you sprinkle a call all over the core
kernel. At the very least make an inline fast path for this function to
avoid the call whenever possible.
> +}
> +#endif
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH v12 07/13] task_isolation: add debug boot flag Peter Zijlstra <peterz@infradead.org> - 2016-05-18 16:00 +0200
Re: [PATCH v12 07/13] task_isolation: add debug boot flag Peter Zijlstra <peterz@infradead.org> - 2016-05-18 19:10 +0200
Re: [PATCH v12 07/13] task_isolation: add debug boot flag Peter Zijlstra <peterz@infradead.org> - 2016-05-19 20:00 +0200
csiph-web