Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1404407
| From | Heiko Stuebner <heiko@sntech.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 |
| Date | 2016-05-20 15:00 +0200 |
| Message-ID | <rASc4-5AE-63@gated-at.bofh.it> (permalink) |
| References | <rAG1b-6u9-5@gated-at.bofh.it> <rAG1b-6u9-9@gated-at.bofh.it> <rARSG-5u5-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Am Freitag, 20. Mai 2016, 20:35:53 schrieb Shawn Lin:
> 在 2016/5/20 7:56, Caesar Wang 写道:
> > That's seem the incorrect string to match the spi driver.
>
> Will it break the backward compatibility for some dtb if not
> falling back to "rockchip,rockchip-spi" ?
in what dtb did you see "rockchip,rockchip-spi"?
I.e. it isn't part of any current _mainline_ devicetree files.
Heiko
>
> > Fixes commit f629fcfab2cd
> > ("ARM: dts: rockchip: support the spi for rk3036")
> >
> > Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: linux-rockchip@lists.infradead.org
> >
> > ---
> >
> > Changes in v2: None
> >
> > arch/arm/boot/dts/rk3036.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/rk3036.dtsi
> > b/arch/arm/boot/dts/rk3036.dtsi index d0f4bb7..a30700a 100644
> > --- a/arch/arm/boot/dts/rk3036.dtsi
> > +++ b/arch/arm/boot/dts/rk3036.dtsi
> > @@ -431,7 +431,7 @@
> >
> > };
> >
> > spi: spi@20074000 {
> >
> > - compatible = "rockchip,rockchip-spi";
> > + compatible = "rockchip,rk3036-spi";
> >
> > reg = <0x20074000 0x1000>;
> > interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > clocks =<&cru PCLK_SPI>, <&cru SCLK_SPI>;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 Caesar Wang <wxt@rock-chips.com> - 2016-05-20 02:00 +0200
Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 Shawn Lin <shawn.lin@kernel-upstream.org> - 2016-05-20 14:40 +0200
Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 Caesar Wang <wxt@rock-chips.com> - 2016-05-20 15:00 +0200
Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-20 15:10 +0200
Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 Heiko Stuebner <heiko@sntech.de> - 2016-05-20 15:00 +0200
Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-20 15:20 +0200
csiph-web