Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1404431

Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas

Show all headers | View raw

> > @@ -82,6 +87,12 @@ void perf_stat__reset_shadow_stats(void)
> >  		sizeof(runtime_transaction_stats));
> >  	memset(runtime_elision_stats, 0, sizeof(runtime_elision_stats));
> >  	memset(&walltime_nsecs_stats, 0, sizeof(walltime_nsecs_stats));
> > +	memset(runtime_topdown_total_slots, 0, sizeof(runtime_topdown_total_slots));
> > +	memset(runtime_topdown_slots_retired, 0, sizeof(runtime_topdown_slots_retired));
> > +	memset(runtime_topdown_slots_issued, 0, sizeof(runtime_topdown_slots_issued));
> > +	memset(runtime_topdown_fetch_bubbles, 0, sizeof(runtime_topdown_fetch_bubbles));
> > +	memset(runtime_topdown_recovery_bubbles, 0, sizeof(runtime_topdown_recovery_bubbles));
> > +	have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend");
> 
> why to initialize this one in here? it's already in perf_stat__init_shadow_stats

You mean the have_frontend_stalled?

I don't think it's in init_shadow_stats yet, but it could be moved.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 8/8] perf stat: Add computation of TopDown formulas Andi Kleen <andi@firstfloor.org> - 2016-05-14 03:50 +0200
  Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas Jiri Olsa <jolsa@redhat.com> - 2016-05-20 12:30 +0200
    Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas Andi Kleen <ak@linux.intel.com> - 2016-05-20 15:40 +0200
      Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas Jiri Olsa <jolsa@redhat.com> - 2016-05-20 15:50 +0200
        Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas Andi Kleen <andi@firstfloor.org> - 2016-05-20 16:20 +0200
    Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas Andi Kleen <ak@linux.intel.com> - 2016-05-20 15:50 +0200

csiph-web