Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1404355
| From | Masami Hiramatsu <mhiramat@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core |
| Date | 2016-05-20 13:40 +0200 |
| Message-ID | <rAQWB-4Vm-15@gated-at.bofh.it> (permalink) |
| References | <rzTWy-T4-11@gated-at.bofh.it> <rzU6e-W9-7@gated-at.bofh.it> <rAbqq-3On-33@gated-at.bofh.it> <rAr2a-5i8-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 19 May 2016 13:19:42 +0530
Anju T <anju@linux.vnet.ibm.com> wrote:
> >> +void arch_unoptimize_kprobes(struct list_head *oplist,
> >> + struct list_head *done_list)
> >> +{
> >> + struct optimized_kprobe *op;
> >> + struct optimized_kprobe *tmp;
> >> +
> >> + list_for_each_entry_safe(op, tmp, oplist, list) {
> >> + arch_unoptimize_kprobe(op);
> >> + list_move(&op->list, done_list);
> >> + }
> >> +}
> >> +
> >> +int arch_within_optimized_kprobe(struct optimized_kprobe *op,
> >> + unsigned long addr)
> >> +{
> > Please make sure addr != op->kp.addr and addr is aligned.
>
> The only case this check will succeed is if kp.addr is not a multiple of 4, which is not a valid address at all on
> Power.So should we again check here for that?
Ah, right. OK, so we may not need that.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 0/3] OPTPROBES for powerpc Anju T <anju@linux.vnet.ibm.com> - 2016-05-17 22:40 +0200
[RFC PATCH 3/3] arch/powerpc : Enable optprobes support in powerpc Anju T <anju@linux.vnet.ibm.com> - 2016-05-17 22:50 +0200
[RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core Anju T <anju@linux.vnet.ibm.com> - 2016-05-17 22:50 +0200
Re: [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core Masami Hiramatsu <mhiramat@kernel.org> - 2016-05-18 17:20 +0200
Re: [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core Anju T <anju@linux.vnet.ibm.com> - 2016-05-19 10:00 +0200
Re: [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core Masami Hiramatsu <mhiramat@kernel.org> - 2016-05-20 13:40 +0200
[RFC PATCH 1/3] arch/powerpc : Add detour buffer support for optprobes Anju T <anju@linux.vnet.ibm.com> - 2016-05-17 22:50 +0200
csiph-web