[PATCH 1/2] staging: dgnc: remove redundant NULL check for brd

From	Daeseok Youn <daeseok.youn@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] staging: dgnc: remove redundant NULL check for brd
Date	2016-05-20 12:00 +0200
Message-ID	<rAPnP-3SW-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

the "brd" value cannot be NULL in dgnc_finalize_board_init().
Because "brd" as a parameter of this function was already
checked for NULL.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
 drivers/staging/dgnc/dgnc_driver.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index af2e835..22257d2 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -579,9 +579,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd)
 {
 	int rc = 0;
 
-	if (!brd || brd->magic != DGNC_BOARD_MAGIC)
-		return -ENODEV;
-
 	if (brd->irq) {
 		rc = request_irq(brd->irq, brd->bd_ops->intr,
 				 IRQF_SHARED, "DGNC", brd);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: dgnc: remove redundant NULL check for brd Daeseok Youn <daeseok.youn@gmail.com> - 2016-05-20 12:00 +0200
  Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-25 23:50 +0200
    Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd DaeSeok Youn <daeseok.youn@gmail.com> - 2016-05-26 07:00 +0200
      Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-26 14:30 +0200
        Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd DaeSeok Youn <daeseok.youn@gmail.com> - 2016-05-27 03:40 +0200

csiph-web