[PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect()

From	Alexander Popov <alpopov@ptsecurity.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect()
Date	2016-05-20 11:40 +0200
Message-ID	<rAP4t-3Mf-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

stub_disconnect() calls stub_device_reset() during usb_unbind_device() when
usb device is locked. So usb_lock_device_for_reset() in stub_device_reset()
in that case polls for one second and returns -EBUSY anyway.

Remove useless flag USBIP_EH_RESET from SDEV_EVENT_REMOVED.

Signed-off-by: Alexander Popov <alpopov@ptsecurity.com>
---
 drivers/usb/usbip/usbip_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/usbip/usbip_common.h b/drivers/usb/usbip/usbip_common.h
index 86b0847..c4b4938 100644
--- a/drivers/usb/usbip/usbip_common.h
+++ b/drivers/usb/usbip/usbip_common.h
@@ -242,7 +242,7 @@ enum usbip_side {
 #define USBIP_EH_RESET		(1 << 2)
 #define USBIP_EH_UNUSABLE	(1 << 3)
 
-#define SDEV_EVENT_REMOVED   (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE)
+#define	SDEV_EVENT_REMOVED	(USBIP_EH_SHUTDOWN | USBIP_EH_BYE)
 #define	SDEV_EVENT_DOWN		(USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
 #define	SDEV_EVENT_ERROR_TCP	(USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
 #define	SDEV_EVENT_ERROR_SUBMIT	(USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect() Alexander Popov <alpopov@ptsecurity.com> - 2016-05-20 11:40 +0200
  Re: [PATCH 1/1] usbip: don't call stub_device_reset() during  stub_disconnect() Alexander Popov <alpopov@ptsecurity.com> - 2016-05-27 16:30 +0200
    Re: [PATCH 1/1] usbip: don't call stub_device_reset() during  stub_disconnect() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-27 18:20 +0200

csiph-web