Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1404261

Re: [PATCH] edac:Fix kernel panic regression in edac_mc_reset_delay_period due to missing mode operation check

Show all headers | View raw

On Thu, May 19, 2016 at 06:45:58PM -0400, Nicholas Krause wrote:
> This fixes a kernel panic regression in the function,
> edac_mc_reset_delay_period as show by this kernel panic
> trace:

...

>  drivers/edac/edac_mc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> index 6aa256b0..c3ee3ad 100644
> --- a/drivers/edac/edac_mc.c
> +++ b/drivers/edac/edac_mc.c
> @@ -565,7 +565,8 @@ void edac_mc_reset_delay_period(unsigned long value)
>  	list_for_each(item, &mc_devices) {
>  		mci = list_entry(item, struct mem_ctl_info, link);
>  
> -		edac_mod_work(&mci->work, value);
> +		if (mci->op_state == OP_RUNNING_POLL)
> +			edac_mod_work(&mci->work, value);
>  	}
>  	mutex_unlock(&mem_ctls_mutex);
>  }
> -- 

Looks good to me. I'll apply it after the merge window is over.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] edac:Fix kernel panic regression in  edac_mc_reset_delay_period due to missing mode operation check Borislav Petkov <bp@alien8.de> - 2016-05-20 10:50 +0200

csiph-web