Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1404271

Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms

From Carlo Caione <carlo@caione.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms
Date 2016-05-20 11:20 +0200
Message-ID <rAOL8-3Eg-7@gated-at.bofh.it> (permalink)
References <rANYJ-38Z-5@gated-at.bofh.it> <rANYK-38Z-25@gated-at.bofh.it> <rAOi5-3fo-1@gated-at.bofh.it> <rAOrL-3iw-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 20/05/16 10:53, Neil Armstrong wrote:
> On 05/20/2016 10:47 AM, Carlo Caione wrote:
> > On 20/05/16 10:27, Neil Armstrong wrote:
> >> Update DTSI file to add the reset controller node.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >> ---
> >>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> index 832815d..2463e04 100644
> >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> >> @@ -129,6 +129,12 @@
> >>  			#size-cells = <2>;
> >>  			ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>;
> >>  
> >> +			reset: reset-controller@4404 {
> >> +				compatible = "amlogic,meson-gxbb-reset";
> >> +				reg = <0x0 0x04404 0x0 0x20>;
> >> +				#reset-cells = <1>;
> >> +			};
> >> +
> >>  			uart_A: serial@84c0 {
> >>  				compatible = "amlogic,meson-uart";
> >>  				reg = <0x0 0x084c0 0x0 0x14>;
> > 
> > Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ?
> > 
> > Thanks,
> > 
> 
> Shouldn't we wait until the reset bindings are actually used in the dtsi ?
> I'm quite sure kevin will post it with the Ethernet nodes.

Why? The header file is related to the reset controller. Better add it
now with this patchset.

Cheers,

-- 
Carlo Caione

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] Amlogic: GXBB: Add reset controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 10:30 +0200
  [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 10:30 +0200
    Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset  Controller Carlo Caione <carlo@caione.org> - 2016-05-20 11:10 +0200
      Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset  Controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 11:20 +0200
        Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset  Controller Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-20 11:30 +0200
        Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset  Controller Carlo Caione <carlo@caione.org> - 2016-05-20 12:10 +0200
          Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset  Controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 14:30 +0200
            Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset  Controller Carlo Caione <carlo@caione.org> - 2016-05-20 14:30 +0200
    Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset  Controller Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-20 11:30 +0200
      Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset  Controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 14:20 +0200
  [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 10:30 +0200
    Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on  GXBB-based platforms Carlo Caione <carlo@caione.org> - 2016-05-20 10:50 +0200
      Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on  GXBB-based platforms Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 11:00 +0200
        Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on  GXBB-based platforms Carlo Caione <carlo@caione.org> - 2016-05-20 11:20 +0200
          Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on  GXBB-based platforms Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 14:20 +0200
            Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on  GXBB-based platforms Carlo Caione <carlo@caione.org> - 2016-05-20 14:30 +0200
              Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on  GXBB-based platforms Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 14:30 +0200
  [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 10:30 +0200
    Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB  Reset Controller Carlo Caione <carlo@caione.org> - 2016-05-20 10:50 +0200
      Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB  Reset Controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 11:00 +0200
        Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB  Reset Controller Carlo Caione <carlo@caione.org> - 2016-05-20 11:10 +0200
          Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB  Reset Controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-20 14:20 +0200
    Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB  Reset Controller Rob Herring <robh@kernel.org> - 2016-05-23 23:10 +0200

csiph-web