Re: [PATCH v3 3/5] mmc: core: implement enhanced strobe support

From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/5] mmc: core: implement enhanced strobe support
Date	2016-05-20 04:30 +0200
Message-ID	<rAIml-86S-7@gated-at.bofh.it> (permalink)
References	<rxbPY-7V1-17@gated-at.bofh.it> <rxbZE-7Z2-15@gated-at.bofh.it> <rAGkx-6PD-11@gated-at.bofh.it> <rAHJD-7zo-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Shawn,

On Thu, May 19, 2016 at 6:48 PM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>>>   #define EXT_CSD_BUS_WIDTH_1    0       /* Card is in 1 bit mode */
>>>   #define EXT_CSD_BUS_WIDTH_4    1       /* Card is in 4 bit mode */
>>>   #define EXT_CSD_BUS_WIDTH_8    2       /* Card is in 8 bit mode */
>>>   #define EXT_CSD_DDR_BUS_WIDTH_4        5       /* Card is in 4 bit DDR
>>> mode */
>>>   #define EXT_CSD_DDR_BUS_WIDTH_8        6       /* Card is in 8 bit DDR
>>> mode */
>>> +#define EXT_CSD_BUS_WIDTH_STROBE BIT(7)        /* Enhanced strobe mode
>>> */
>>
>>
>> nit: while your code should be OK, it seems better to be BIT(3), since
>> above is really:
>>
>
> I don't unstand here. EXT_CSD_BUS_WIDTH_STROBE is the MSB of
> BUS_WIDTH[183] which is a 8-bit reg.

I totally misunderstood.  You are correct.

-Doug

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 3/5] mmc: core: implement enhanced strobe support Doug Anderson <dianders@chromium.org> - 2016-05-20 02:20 +0200
  Re: [PATCH v3 3/5] mmc: core: implement enhanced strobe support Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-20 03:50 +0200
    Re: [PATCH v3 3/5] mmc: core: implement enhanced strobe support Doug Anderson <dianders@chromium.org> - 2016-05-20 04:30 +0200

csiph-web