Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1403926

Re: [PATCH] iio: light: jsa1212: remove unneeded i2c check functionality test

Show all headers | View raw

Looks Good.

Reviewed-by:Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>


On 05/15/2016 11:37 AM, Alison Schofield wrote:
> This driver does not call i2c_smbus_read|write_byte_data(),
> so remove the corresponding functionality test. It uses regmap
> to handle byte transfers transparently.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> ---
> Found & fixed by inspection based on same defect recently fixed
> in light/tpl0102 driver.
>
>
>   drivers/iio/light/jsa1212.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/light/jsa1212.c b/drivers/iio/light/jsa1212.c
> index 99a6281..e8a8931 100644
> --- a/drivers/iio/light/jsa1212.c
> +++ b/drivers/iio/light/jsa1212.c
> @@ -325,9 +325,6 @@ static int jsa1212_probe(struct i2c_client *client,
>   	struct regmap *regmap;
>   	int ret;
>   
> -	if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA))
> -		return -EOPNOTSUPP;
> -
>   	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
>   	if (!indio_dev)
>   		return -ENOMEM;

-- 
Sathyanarayanan Kuppuswamy
Android kernel developer

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: light: jsa1212: remove unneeded i2c check functionality  test Alison Schofield <amsfield22@gmail.com> - 2016-05-16 04:10 +0200
  Re: [PATCH] iio: light: jsa1212: remove unneeded i2c check  functionality test sathyanarayanan kuppuswamy   <sathyanarayanan.kuppuswamy@linux.intel.com> - 2016-05-19 20:50 +0200
    Re: [PATCH] iio: light: jsa1212: remove unneeded i2c check  functionality test Matt Ranostay <mranostay@gmail.com> - 2016-05-19 22:20 +0200
      Re: [PATCH] iio: light: jsa1212: remove unneeded i2c check  functionality test Jonathan Cameron <jic23@kernel.org> - 2016-05-21 21:20 +0200

csiph-web