Re: [RFC 11/13] mm, compaction: add the ultimate direct compaction priority

From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [RFC 11/13] mm, compaction: add the ultimate direct compaction priority
Date	2016-05-18 14:50 +0200
Message-ID	<rA95f-2dr-19@gated-at.bofh.it> (permalink)
References	<rxaqR-6fU-5@gated-at.bofh.it> <rxaqR-6fU-3@gated-at.bofh.it> <ryltU-49j-21@gated-at.bofh.it> <rzkYO-3UW-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/16/2016 09:17 AM, Vlastimil Babka wrote:
>> >Wouldn't it be better to pull the prio check into compaction_deferred
>> >directly? There are more callers and I am not really sure all of them
>> >would behave consistently.
> I'll check, thanks.

Hm so the other callers of compaction_deferred() are in the context 
where there's no direct compaction priority set. They would have to pass 
something like DEF_COMPACT_PRIORITY. That starts getting subtle so I'd 
rather not go that way.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC 11/13] mm, compaction: add the ultimate direct compaction  priority Michal Hocko <mhocko@kernel.org> - 2016-05-13 15:40 +0200
  Re: [RFC 11/13] mm, compaction: add the ultimate direct compaction  priority Vlastimil Babka <vbabka@suse.cz> - 2016-05-16 09:20 +0200
    Re: [RFC 11/13] mm, compaction: add the ultimate direct compaction  priority Michal Hocko <mhocko@kernel.org> - 2016-05-16 10:20 +0200
    Re: [RFC 11/13] mm, compaction: add the ultimate direct compaction  priority Vlastimil Babka <vbabka@suse.cz> - 2016-05-18 14:50 +0200

csiph-web