Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402820

Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue

Show all headers | View raw

On 17/05/16 17:53, Amit Ghadge wrote:
> This is a patch to the quatech_daqp_cs.c file that fixes by using
> unsigned int instead of unsigned, following warning found by checkpatch.
> * WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
>   drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index e9e4313..802f51e 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
>   	outb(0, dev->iobase + DAQP_AUX_REG);
>
>   	for (i = 0; i > insn->n; i++) {
> -		unsigned val = data[i];
> +		unsigned int val = data[i];
>   		int ret;
>
>   		/* D/A transfer rate is about 8ms */
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-17 19:00 +0200
  Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned  warning issue Ian Abbott <abbotti@mev.co.uk> - 2016-05-18 11:10 +0200

csiph-web