Re: sched: tweak select_idle_sibling to look for idle threads

From	Mike Galbraith <umgwanakikbuti@gmail.com>
Newsgroups	linux.kernel
Subject	Re: sched: tweak select_idle_sibling to look for idle threads
Date	2016-05-18 08:50 +0200
Message-ID	<rA3sS-6TD-9@gated-at.bofh.it> (permalink)
References	(6 earlier) <rwPPs-2FZ-27@gated-at.bofh.it> <rx9XQ-5Zf-21@gated-at.bofh.it> <rxaAz-6l0-51@gated-at.bofh.it> <rxhLI-517-13@gated-at.bofh.it> <rxsxs-7Dd-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-05-11 at 03:16 +0800, Yuyang Du wrote:

> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -3027,6 +3027,9 @@ void remove_entity_load_avg(struct sched
> >  
> >  static inline unsigned long cfs_rq_runnable_load_avg(struct cfs_rq *cfs_rq)
> >  {
> > +> > 	> > if (sched_feat(LB_TIP_AVG_HIGH) && cfs_rq->load.weight > cfs_rq->runnable_load_avg*2)
> > +> > 	> > 	> > return cfs_rq->runnable_load_avg + min_t(unsigned long, NICE_0_LOAD,
> > +> > 	> > 	> > 	> > 	> > 	> > 	> > 	> >  cfs_rq->load.weight/2);
> >  > > 	> > return cfs_rq->runnable_load_avg;
> >  }
>   
> cfs_rq->runnable_load_avg is for sure no greater than (in this case much less
> than, maybe 1/2 of) load.weight, whereas load_avg is not necessarily a rock
> in gearbox that only impedes speed up, but also speed down.

BTW, the reason hack helped is that the long (30ms) sleep/run cycle of
the benchmark's default settings causes large amplitude sawtooth of
load numbers (~300 - ~700 range), dinging up load delta resolvability.

	-Mike

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: sched: tweak select_idle_sibling to look for idle threads Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-05-18 08:50 +0200

csiph-web