Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402717

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Show all headers | View raw

Hi,

On Tue, May 17, 2016 at 7:08 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> On 05/18/2016 09:47 AM, Doug Anderson wrote:
>> Jaehoon,
>>
>> On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson <dianders@chromium.org> wrote:
>>> Jaehoon,
>>>
>>> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>> Dear Doug,
>>>>
>>>> I'm considering to control HLE error..So holding this patch.
>>>> If this is absolutely necessary patch, let me know, plz.
>>>>
>>>> Best Regards,
>>>> Jaehoon Chung
>>>
>>> Sounds OK.  I have certainly applied this locally and the driver isn't
>>> robust against insertions / removals without it, but once the card is
>>> inserted things are OK so it's probably not urgent that it be applied
>>> upstream.  Hopefully we can figure out a better solution...
>>
>> I'm now testing a nice new rebased kernel and I'm hitting this again.
>>
>> Of course I'll just pick my same patch to my new kernel tree, but
>> since it's been a year and nobody has done anything better, would you
>> consider landing my patch?  It is certainly better than nothing.
>
> Sure, it's right.
> I think that main reason of HLE is wait_prvdata_complete. (I'm guessing..)
> On other hands, dwmmc controller is handling something wrong. (I found that HLE is occurred the similar case.)
> After find the main solution, it's not bad that your patch is applied on dwmmc controller.
>
> Ulf have sent PR for next..So if we needs to apply this, i will apply on fix.

It's not new, so I'd say just queue it up for the next version
whenever it's convenient.

-Doug

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors Doug Anderson <dianders@chromium.org> - 2016-05-18 02:50 +0200
  Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command  errors Jaehoon Chung <jh80.chung@samsung.com> - 2016-05-18 04:10 +0200
    Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors Doug Anderson <dianders@chromium.org> - 2016-05-18 06:20 +0200
  Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command  errors Shawn Lin <shawn.lin@kernel-upstream.org> - 2016-05-18 04:10 +0200
    Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors Doug Anderson <dianders@chromium.org> - 2016-05-18 06:20 +0200
      Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command  errors Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-18 11:20 +0200
        Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors Doug Anderson <dianders@chromium.org> - 2016-05-18 19:40 +0200
          Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors Heiko Stuebner <heiko@sntech.de> - 2016-05-18 20:10 +0200
          Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command  errors Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-19 13:40 +0200
            Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command  errors Jaehoon Chung <jh80.chung@samsung.com> - 2016-05-19 15:10 +0200
              Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command  errors Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-26 04:30 +0200
                Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command  errors Jaehoon Chung <jh80.chung@samsung.com> - 2016-05-26 06:00 +0200
                Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command  errors Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-26 06:10 +0200

csiph-web