Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1350930

Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes

From Michal Nazarewicz <mina86@mina86.com>
Newsgroups linux.kernel
Subject Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes
Date 2016-03-05 17:30 +0100
Message-ID <r9nfA-kR-5@gated-at.bofh.it> (permalink)
References <r8kMN-4cl-3@gated-at.bofh.it> <r8kMO-4cl-25@gated-at.bofh.it> <r93qx-2YX-9@gated-at.bofh.it> <r94mB-3EH-5@gated-at.bofh.it>
Organization http://mina86.com/

Show all headers | View raw


>> On Wed, Mar 02 2016, Felipe F. Tonello wrote:
>>> @@ -16,7 +16,7 @@
>>>   *   Copyright (C) 2006 Thumtronics Pty Ltd.
>>>   *   Ben Williamson <ben.williamson@greyinnovation.com>
>>>   *
>>> - * Licensed under the GPL-2 or later.
>>> + * Licensed under the GPLv2.

> On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz <mina86@mina86.com> wrote:
>> Any particular reason to do that?

On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote:
> Because the kernel is v2 only and not later. 

Linux as a whole is GPLv2 only, but that doesn’t necessarily mean that
parts of it cannot be dual licensed (or GPLv2+).  It’s safer to leave
copyright noticed clear unless you explicitly want your contribution be
GPLv2 only which brings the whole file GPLv2 only.

> I just tried to make this driver more consistent with the coding style
> used across the kernel. That's it.

Column alignment of field names or RHS of assignment operators is quite
inconsistent already within drivers/usb/gadget/ which is why I’m
concerned whether this is really helping.

Anyway, I actually don’t care much, just adding my two rappen.

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Michal Nazarewicz <mina86@mina86.com> - 2016-03-04 20:20 +0100
  Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-03-04 21:20 +0100
    Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Michal Nazarewicz <mina86@mina86.com> - 2016-03-05 17:30 +0100
      Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Greg KH <greg@kroah.com> - 2016-03-05 20:40 +0100
        Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-03-06 01:00 +0100
          Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Greg KH <greg@kroah.com> - 2016-03-06 04:10 +0100
      Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-03-06 01:00 +0100
        Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Felipe Balbi <balbi@kernel.org> - 2016-03-07 08:40 +0100
          Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-03-07 10:40 +0100
            Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes Felipe Balbi <balbi@kernel.org> - 2016-03-08 08:50 +0100

csiph-web