Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs
Date	2016-03-05 13:50 +0100
Message-ID	<r9jOF-6fy-3@gated-at.bofh.it> (permalink)
References	<r5Eym-2WS-21@gated-at.bofh.it> <r5FE7-3ID-49@gated-at.bofh.it> <r6fRg-4jE-17@gated-at.bofh.it> <r6gtX-4Py-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Feb 26, 2016 at 10:31:50AM +0800, Huang, Tao wrote:

> You misunderstand me. I talk about spi_setup, as
> Documentation/spi/spi-summary, which would normally be called from
> probe() before the first I/O is done to the device.
> spi_setup will call spi_set_cs(spi, false), which introduced with commit
> 1a7b7ee72c21 ("spi: Ensure that CS line is in non-active state after
> spi_setup()"). And spi_set_cs will call spi->master->set_cs, and set_cs
> callback will access register. Without clk enable, I believe some
> drivers will failed to run.

That's definitely very driver specific, a large proportion of devices
don't manage their chip selects via the SPI controller at all.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] spi/rockchip: Make sure spi clk is on in  rockchip_spi_set_cs Mark Brown <broonie@kernel.org> - 2016-03-05 13:50 +0100

csiph-web