Re: [patch -target tree] usb: gadget: f_tcm: use after free

From	"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Newsgroups	linux.kernel
Subject	Re: [patch -target tree] usb: gadget: f_tcm: use after free
Date	2016-03-05 08:30 +0100
Message-ID	<r9eOZ-2Kw-3@gated-at.bofh.it> (permalink)
References	<r8bTd-6bA-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-03-02 at 13:08 +0300, Dan Carpenter wrote:
> We need to move the kfree() down a line so we don't dereference a freed
> variable.
> 
> Fixes: 1b418a8fcbc0 ('target: Convert demo-mode only drivers to target_alloc_session')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
> index 7276a73..e352a31 100644
> --- a/drivers/usb/gadget/function/f_tcm.c
> +++ b/drivers/usb/gadget/function/f_tcm.c
> @@ -1596,8 +1596,8 @@ static int tcm_usbg_make_nexus(struct usbg_tpg *tpg, char *name)
>  #define MAKE_NEXUS_MSG "core_tpg_check_initiator_node_acl() failed for %s\n"
>  		pr_debug(MAKE_NEXUS_MSG, name);
>  #undef MAKE_NEXUS_MSG
> -		kfree(tv_nexus);
>  		ret = PTR_ERR(tv_nexus->tvn_se_sess);
> +		kfree(tv_nexus);
>  	}
>  
>  out_unlock:

Fixed + squashed into the original patch.

Thanks Dan.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [patch -target tree] usb: gadget: f_tcm: use after free "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-03-05 08:30 +0100

csiph-web