Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature
Date	2016-03-07 09:40 +0100
Message-ID	<r9YRQ-rn-15@gated-at.bofh.it> (permalink)
References	<r7sMr-1iX-33@gated-at.bofh.it> <r89HI-4v3-3@gated-at.bofh.it> <r8p05-7eU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Mar 02, 2016 at 04:08:33PM -0800, Matt Longnecker wrote:
> 
> 
> On 03/01/2016 11:40 PM, Wei Ni wrote:
> >>diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> >>index 74ea5765938b..136975220c92 100644
> >>--- a/drivers/thermal/tegra_soctherm.c
> >>+++ b/drivers/thermal/tegra_soctherm.c
> >>@@ -57,7 +57,7 @@
> >>  #define READBACK_VALUE_MASK			0xff00
> >>  #define READBACK_VALUE_SHIFT			8
> >>  #define READBACK_ADD_HALF			BIT(7)
> >>-#define READBACK_NEGATE				BIT(1)
> >>+#define READBACK_NEGATE				BIT(0)
> I confirm that this change is technically correct. It fixes a bug.

That usually translates to a Reviewed-by: tag. =)

Thierry

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Thierry Reding <thierry.reding@gmail.com> - 2016-03-07 09:40 +0100

csiph-web