Re: [tip:mm/pkeys] mm/pkeys: Fix siginfo ABI breakage caused by new u64 field

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [tip:mm/pkeys] mm/pkeys: Fix siginfo ABI breakage caused by new u64 field
Date	2016-03-06 19:50 +0100
Message-ID	<r9LUB-oi-5@gated-at.bofh.it> (permalink)
References	<r7S4b-Pg-23@gated-at.bofh.it> <r8ELx-1ze-43@gated-at.bofh.it> <r8Fez-21e-31@gated-at.bofh.it> <r9kUq-6YR-15@gated-at.bofh.it> <r9nID-wr-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Mar 5, 2016 at 8:52 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Sat, Mar 05, 2016 at 02:50:06PM +0100, Ingo Molnar wrote:
>> A more workable method would be to have a test .c file that includes all UAPI
>> structures in existence and defines a variable out of every single one, and then
>> generates a list of sizeof() values or so. But even that isn't perfect: a
>> structure might shift some fields forward, into a pre-existing hole, without
>> changing the sizeof? We'd need a list of all field offsets in all structures to be
>> really sure, and that's nasty.
>
> pahole has such logic, right?

sparse could be taught to warn about unaligned u64's, but there are
still config issues and issues across other architectures, and if some
case gets missed it can be really quite painful.

          Linus

Thread

Re: [tip:mm/pkeys] mm/pkeys: Fix siginfo ABI breakage caused by new  u64 field Ingo Molnar <mingo@kernel.org> - 2016-03-05 15:00 +0100
  Re: [tip:mm/pkeys] mm/pkeys: Fix siginfo ABI breakage caused by new  u64 field Peter Zijlstra <peterz@infradead.org> - 2016-03-05 18:00 +0100
    Re: [tip:mm/pkeys] mm/pkeys: Fix siginfo ABI breakage caused by new  u64 field Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-06 19:50 +0100
      Re: [tip:mm/pkeys] mm/pkeys: Fix siginfo ABI breakage caused by new  u64 field Ingo Molnar <mingo@kernel.org> - 2016-03-07 10:00 +0100

csiph-web