Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1350617

Re: [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP

From Emil Velikov <emil.l.velikov@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP
Date 2016-03-04 22:40 +0100
Message-ID <r95C1-4Cy-11@gated-at.bofh.it> (permalink)
References <r8VCF-5oY-5@gated-at.bofh.it> <r8VCF-5oY-3@gated-at.bofh.it> <r8VMl-5IQ-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Nicolas,

On 4 March 2016 at 10:52, Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> Let's use __KERNEL_DIV_ROUND_UP, which is defined in uapi/linux/kernel.h.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
>  .../drm/vmwgfx/device_include/svga3d_surfacedefs.h   | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h b/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h
> index 58704f0a4607..531d22025fec 100644
> --- a/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h
> +++ b/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h
> @@ -25,6 +25,8 @@
>   *
>   **************************************************************************/
>
> +#include <linux/kernel.h>
> +
Files from DRM modules tend to be used in various (crazy) ways. Be
that in linux and/or other user space.

Fairly certain that everything is fine here, just adding one of the
core vmwgfx developers.

Thomas, this won't cause any issues would it ?

Can you guys please add an entry for vmwgfx to MAINTAINERS, so that
people can CC you guys on patches that touch the driver ?

Thanks
Emil

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-03-04 12:00 +0100
  [PATCH net-next v3 4/4] ethtool.h: define INT_MAX for userland Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-03-04 12:00 +0100
    Re: [PATCH net-next v3 4/4] ethtool.h: define INT_MAX for userland Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2016-03-04 14:20 +0100
  [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-03-04 12:10 +0100
    Re: [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-04 22:40 +0100
  [PATCH net-next v3 2/4] cxgb4i: don't redefine DIV_ROUND_UP Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-03-04 12:10 +0100
  Re: [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP  definition David Miller <davem@davemloft.net> - 2016-03-04 22:20 +0100

csiph-web