Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1350449

Re: [PATCH] staging/android: add flags member to sync ioctl structs

Show all headers | View raw

On Thu, Mar 03, 2016 at 08:17:14AM -0800, Greg Kroah-Hartman wrote:
> On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > Play safe and add flags member to all structs. So we don't need to
> > break API or create new IOCTL in the future if new features that requires
> > flags arises.
> > 
> > v2: check if flags are valid (zero, in this case)
> > 
> > v3: return -EINVAL if flags are not zero'ed
> > 
> > v4: add padding for 64-bit alignment
> > 
> > v5: rebase to use only stacked sync_file_info
> 
> Why are these vX things here in the changelog?

Because this is drm and we're special ;-)

> And you just broke all existing userspace users of this code, why are
> you allowed to do that?
> 
> not ok...

We could do fence2.h if you absolutely insist and just forget about the
current one, but that seemed silly. Like Gustavo said, everyone who
actually cares about this stuff is perfectly fine with this. And there's
not a single user of this in upstream anyway, so the only trees we could
break are vendor trees with massive amounts of additional stuff.

Is that reasonable ok for you, or do you insist we do a fences2.h without
going through staging ? ;-)

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 1/6] staging/android: add num_fences field to struct sync_file_info Gustavo Padovan <gustavo@padovan.org> - 2016-03-02 21:00 +0100
  [PATCH v6 3/6] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan <gustavo@padovan.org> - 2016-03-02 21:00 +0100
  [PATCH v6 6/6] staging/android: add flags member to sync ioctl structs Gustavo Padovan <gustavo@padovan.org> - 2016-03-02 21:00 +0100
    [PATCH] staging/android: add flags member to sync ioctl structs Gustavo Padovan <gustavo@padovan.org> - 2016-03-02 23:00 +0100
      [PATCH] staging/android: add flags member to sync ioctl structs Gustavo Padovan <gustavo@padovan.org> - 2016-03-03 15:40 +0100
        Re: [PATCH] staging/android: add flags member to sync ioctl structs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-03 17:20 +0100
          Re: [PATCH] staging/android: add flags member to sync ioctl structs Gustavo Padovan <gustavo.padovan@collabora.co.uk> - 2016-03-03 20:20 +0100
            Re: [PATCH] staging/android: add flags member to sync ioctl structs Gustavo Padovan <gustavo@padovan.org> - 2016-03-03 20:50 +0100
          Re: [PATCH] staging/android: add flags member to sync ioctl structs Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-03-03 21:10 +0100
          Re: [PATCH] staging/android: add flags member to sync ioctl structs Rob Clark <robdclark@gmail.com> - 2016-03-03 22:00 +0100
            Re: [PATCH] staging/android: add flags member to sync ioctl structs Rob Clark <robdclark@gmail.com> - 2016-03-03 22:50 +0100
          Re: [PATCH] staging/android: add flags member to sync ioctl structs Daniel Vetter <daniel@ffwll.ch> - 2016-03-04 17:50 +0100
            Re: [PATCH] staging/android: add flags member to sync ioctl structs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-11 23:00 +0100
          Re: [PATCH] staging/android: add flags member to sync ioctl structs Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-05 14:00 +0100
  [PATCH v6 2/6] staging/android: rename SYNC_IOC_FENCE_INFO Gustavo Padovan <gustavo@padovan.org> - 2016-03-02 21:00 +0100

csiph-web