Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1350344

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

Show all headers | View raw

On Wed, 2 Mar 2016, Sedat Dilek wrote:

> On 3/1/16, Alan Stern <stern@rowland.harvard.edu> wrote:
> > On Tue, 1 Mar 2016, Sedat Dilek wrote:
> >
> >> On Tue, Oct 13, 2015 at 2:57 AM, Steven Rostedt <rostedt@goodmis.org>
> >> wrote:
> >> > On Sat, 3 Oct 2015 12:05:42 +0200
> >> > Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >> >
> >> >> So, at the beginning... dunno WTF is causing the problems - no
> >> >> workaround for CLANG.
> >> >
> >> > Probably need to compile with gcc and with clang and look at the binary
> >> > differences. Or at least what objdump shows.
> >> >
> >>
> >> [ Hope to address this issue to the correct people - CCed some people
> >> I taped on their nerves ]
> >>
> >> Not sure if I should open a new thread?
> >> Please, some clear statements on this.
> >> Thanks.
> >>
> >> The issue is still visible and alive.

I think it would be worthwhile to doublecheck the time at which
interrupts get disabled.  Sedat, please try your plug/unplug the USB
mouse test with the patch below.

Alan Stern



Index: usb-4.4/drivers/hid/usbhid/hid-core.c
===================================================================
--- usb-4.4.orig/drivers/hid/usbhid/hid-core.c
+++ usb-4.4/drivers/hid/usbhid/hid-core.c
@@ -1393,8 +1393,11 @@ static void usbhid_disconnect(struct usb
 
 static void hid_cancel_delayed_stuff(struct usbhid_device *usbhid)
 {
+	if (raw_irqs_disabled())  pr_info("usbhid irqs disabled A\n");
 	del_timer_sync(&usbhid->io_retry);
+	if (raw_irqs_disabled())  pr_info("usbhid irqs disabled B\n");
 	cancel_work_sync(&usbhid->reset_work);
+	if (raw_irqs_disabled())  pr_info("usbhid irqs disabled C\n");
 }
 
 static void hid_cease_io(struct usbhid_device *usbhid)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning Alan Stern <stern@rowland.harvard.edu> - 2016-03-04 17:10 +0100

csiph-web