Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348990

Re: [RFC 10/15] net: ethernet: Add missing MFD_SYSCON dependency on HAS_IOMEM

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [RFC 10/15] net: ethernet: Add missing MFD_SYSCON dependency on HAS_IOMEM
Date 2016-03-03 12:10 +0100
Message-ID <r8ziO-6bR-9@gated-at.bofh.it> (permalink)
References <r8wuB-48P-3@gated-at.bofh.it> <r8wEk-4cL-57@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thursday 03 March 2016 17:03:36 Krzysztof Kozlowski wrote:
> The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
> direct dependencies.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/net/ethernet/hisilicon/Kconfig      | 1 +
>  drivers/net/ethernet/stmicro/stmmac/Kconfig | 6 ++++++
>  drivers/net/ethernet/ti/Kconfig             | 1 +
>  3 files changed, 8 insertions(+)
> 
> diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
> index 74beb1867230..6a9c91781bf9 100644
> --- a/drivers/net/ethernet/hisilicon/Kconfig
> +++ b/drivers/net/ethernet/hisilicon/Kconfig
> @@ -26,6 +26,7 @@ config HIX5HD2_GMAC
>  config HIP04_ETH
>  	tristate "HISILICON P04 Ethernet support"
>  	select MARVELL_PHY
> +	depends on HAS_IOMEM	# For MFD_SYSCON
>  	select MFD_SYSCON
>  	select HNS_MDIO
>  	---help---

Geert added a HAS_DMA dependency in linux-next, which takes
care of this, although it's still technically correct as well.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index cec147d1d34f..d6902bf6e90f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -16,6 +16,7 @@ if STMMAC_ETH
>  config STMMAC_PLATFORM
>  	tristate "STMMAC Platform bus support"
>  	depends on STMMAC_ETH
> +	depends on HAS_IOMEM	# For MFD_SYSCON
>  	select MFD_SYSCON
>  	default y
>  	---help---

NET_VENDOR_STMICRO depends on HAS_IOMEM, so we are good here for the
entire directory.

> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index e7f0b7d95b65..ec56cebe929d 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -62,6 +62,7 @@ config TI_CPSW_ALE
>  config TI_CPSW
>  	tristate "TI CPSW Switch Support"
>  	depends on ARCH_DAVINCI || ARCH_OMAP2PLUS
> +	depends on HAS_IOMEM	# For MFD_SYSCON
>  	select TI_DAVINCI_CPDMA
>  	select TI_DAVINCI_MDIO
>  	select TI_CPSW_PHY_SEL
> 


This again is platform specific, so the chagnge is not needed.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 00/15] tree-wide: mfd: syscon: Fix unmet ioremap dependency Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:10 +0100
  [RFC 11/15] power: reset: keystone: Add missing MFD_SYSCON dependency  on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:10 +0100
    Re: [RFC 11/15] power: reset: keystone: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:10 +0100
      Re: [RFC 11/15] power: reset: keystone: Add missing MFD_SYSCON  dependency on HAS_IOMEM Sebastian Reichel <sre@kernel.org> - 2016-03-03 13:40 +0100
        Re: [rtc-linux] Re: [RFC 11/15] power: reset: keystone: Add missing  MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 13:40 +0100
  [RFC 14/15] usb: xhci: mtk: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:10 +0100
    Re: [RFC 14/15] usb: xhci: mtk: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:10 +0100
  [RFC 01/15] clocksource: atmel: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [RFC 01/15] clocksource: atmel: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:00 +0100
  [RFC 07/15] pinctrl: mvebu: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [rtc-linux] [RFC 07/15] pinctrl: mvebu: Add missing MFD_SYSCON  dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 13:50 +0100
  [RFC 02/15] dmaengine: nxp: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [RFC 02/15] dmaengine: nxp: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:00 +0100
  [RFC 06/15] pinctrl: rockchip: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [rtc-linux] [RFC 06/15] pinctrl: rockchip: Add missing MFD_SYSCON  dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 13:50 +0100
  [RFC 03/15] hwspinlock: qcom: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [RFC 03/15] hwspinlock: qcom: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:00 +0100
  [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:00 +0100
      Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-03 13:30 +0100
        Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 14:10 +0100
  [RFC 05/15] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [RFC 05/15] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:00 +0100
  [RFC 10/15] net: ethernet: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [RFC 10/15] net: ethernet: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:10 +0100
  [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
    Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 12:00 +0100
      Re: [rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON  dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 13:10 +0100
        Re: [rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON  dependency on HAS_IOMEM Krzysztof Kozłowski <k.kozlowski.k@gmail.com> - 2016-03-03 13:40 +0100
        Re: [rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM Arnd Bergmann <arnd@arndb.de> - 2016-03-03 13:40 +0100

csiph-web