Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller

From	Parav Pandit <pandit.parav@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller
Date	2016-03-03 09:40 +0100
Message-ID	<r8wXG-4lu-41@gated-at.bofh.it> (permalink)
References	(1 earlier) <r7XQd-4Tj-1@gated-at.bofh.it> <r8j4l-2TR-1@gated-at.bofh.it> <r8l6a-4lm-19@gated-at.bofh.it> <r8rXZ-Ry-29@gated-at.bofh.it> <r8wXG-4lu-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 3, 2016 at 1:44 PM, Haggai Eran <haggaie@mellanox.com> wrote:
> On 03/03/2016 05:18, Parav Pandit wrote:
>> On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit <pandit.parav@gmail.com> wrote:
>>> On Wed, Mar 2, 2016 at 11:09 PM, Tejun Heo <tj@kernel.org> wrote:
>>>> Nothing seems to prevent @cg from going away if this races with
>>>> @current being migrated to a different cgroup.  Have you run this with
>>>> lockdep and rcu debugging enabled?  This should have triggered a
>>>> warning.
>> I am able to reproduce this race. Looking into how to address it.
>
> If I understand correctly, task_css() requires rcu read lock being held.
> Is task_get_css() suitable here?

Yes. Its suitable if we continue with newer API to drop "num" entries.
Or I will have make minor modification to support that in cgroup.h.
There is no variation as task_get_css_many, but its minor change anyway.
I saw slept off yesterday night, saw today morning.
Will test over weekend and wait for Tejun's opinion if there is any.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv9 1/3] rdmacg: Added rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-03-01 20:10 +0100
  Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller Tejun Heo <tj@kernel.org> - 2016-03-02 18:50 +0100
    Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-03-02 21:00 +0100
      Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-03-03 03:50 +0100
      Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-03-03 04:20 +0100
        Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-03-03 09:40 +0100

csiph-web