Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348742

Re: [PATCH 2/2] objtool: Support CROSS_COMPILE

Show all headers | View raw

On Thu, Mar 03, 2016 at 01:43:14PM +1100, Stephen Rothwell wrote:
> Hi Josh,
> 
> Just a couple of quick comments ...
> 
> On Wed,  2 Mar 2016 18:39:37 -0600 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> >
> > diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> > index c4f0713..e4a6bd5 100644
> > --- a/tools/objtool/Makefile
> > +++ b/tools/objtool/Makefile
> 
> I was wondering if this would be more appropriate in scripts/objtool
> since it is used during the building of the kernel.  Or does it have a
> wider use?

Yeah, it was actually in the scripts/ dir in earlier revisions of the
patch set, for that very reason.  However, Ingo pointed out that it
could be useful beyond the kernel, so we graduated it to a "tool".

> > @@ -7,13 +7,19 @@ ARCH := x86
> >  endif
> >  endif
> >  
> > +# always use the host compiler
> > +CC = gcc
> 
> We have HOSTCC with its associated HOSTCFLAGS etc ... I am not sure if
> that is more appropriate (but it does take care of people using clang).

The "tools" are almost completely separate from the rest of the kernel.
They have their own scaled-down version of kbuild, which doesn't have
HOSTCC.

But yeah, we might eventually need to copy some of the host compilation
infrastructure from scripts/Makefile.host over to the tools/ side.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the tip tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-01 02:30 +0100
  Re: linux-next: build failure after merge of the tip tree Ingo Molnar <mingo@kernel.org> - 2016-03-01 08:10 +0100
    Re: linux-next: build failure after merge of the tip tree Sedat Dilek <sedat.dilek@gmail.com> - 2016-03-01 08:30 +0100
      Re: linux-next: build failure after merge of the tip tree "H. Peter Anvin" <hpa@zytor.com> - 2016-03-01 08:50 +0100
        Re: linux-next: build failure after merge of the tip tree Sedat Dilek <sedat.dilek@gmail.com> - 2016-03-01 09:50 +0100
        Re: linux-next: build failure after merge of the tip tree Ingo Molnar <mingo@kernel.org> - 2016-03-01 10:50 +0100
    Re: linux-next: build failure after merge of the tip tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-01 10:50 +0100
      [PATCH] objtool: Disable stack validation when CROSS_COMPILE is used Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-01 23:00 +0100
        Re: [PATCH] objtool: Disable stack validation when CROSS_COMPILE is  used Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-02 03:30 +0100
          Re: [PATCH] objtool: Disable stack validation when CROSS_COMPILE is  used Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-02 22:20 +0100
            Re: [PATCH] objtool: Disable stack validation when CROSS_COMPILE is  used Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-02 23:30 +0100
              [PATCH 0/2] objtool: Cross-compilation support Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-03 01:50 +0100
                [PATCH 1/2] x86/asm/decoder: Use explicitly signed chars Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-03 01:50 +0100
                [tip:core/objtool] x86/asm/decoder: Use explicitly signed chars tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2016-03-03 18:00 +0100
                Re: [tip:core/objtool] x86/asm/decoder: Use explicitly signed chars "H. Peter Anvin" <hpa@zytor.com> - 2016-03-03 20:10 +0100
                [PATCH 2/2] objtool: Support CROSS_COMPILE Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-03 01:50 +0100
                Re: [PATCH 2/2] objtool: Support CROSS_COMPILE Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-03 03:50 +0100
                Re: [PATCH 2/2] objtool: Support CROSS_COMPILE Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-03 04:30 +0100
                Re: [PATCH 2/2] objtool: Support CROSS_COMPILE Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-03 04:40 +0100
                Re: [PATCH 2/2] objtool: Support CROSS_COMPILE Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-03 04:50 +0100
                Re: [PATCH 2/2] objtool: Support CROSS_COMPILE Ingo Molnar <mingo@kernel.org> - 2016-03-03 16:20 +0100
                Re: [PATCH 2/2] objtool: Support CROSS_COMPILE Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-04 00:10 +0100
                Re: [PATCH 2/2] objtool: Support CROSS_COMPILE "H. Peter Anvin" <hpa@zytor.com> - 2016-03-03 16:30 +0100
                [tip:core/objtool] objtool: Support CROSS_COMPILE tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2016-03-03 18:10 +0100
          Re: [PATCH] objtool: Disable stack validation when CROSS_COMPILE is used Sedat Dilek <sedat.dilek@gmail.com> - 2016-03-03 08:40 +0100
            Re: [PATCH] objtool: Disable stack validation when CROSS_COMPILE is  used Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-03 09:00 +0100

csiph-web