Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348733

Re: [cgroup/for-4.6 1/2] cgroup: re-hash init_css_set after subsystems are initialized

Show all headers | View raw

On 2016/3/3 2:07, Tejun Heo wrote:
> css_sets are hashed by their subsys[] contents and in cgroup_init()
> init_css_set is hashed early, before subsystem inits, when all entries
> in its subsys[] are NULL, so that cgroup_dfl_root initialization can
> find and link to it.  As subsystems are initialized,
> init_css_set.subsys[] is filled up but the hashing is never updated
> making init_css_set hashed in the wrong place.  While incorrect, this
> doesn't cause a critical failure as css_set management code would
> create an identical css_set dynamically.
> 
> Fix it by rehashing init_css_set after subsystems are initialized.
> While at it, drop unnecessary @key local variable.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>

For both patches:

Acked-by: Zefan Li <lizefan@huawei.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[cgroup/for-4.6 1/2] cgroup: re-hash init_css_set after subsystems  are initialized Tejun Heo <tj@kernel.org> - 2016-03-02 19:10 +0100
  [cgroup/for-4.6 2/2] cgroup: suppress spurious de-populated events Tejun Heo <tj@kernel.org> - 2016-03-02 19:10 +0100
  Re: [cgroup/for-4.6 1/2] cgroup: re-hash init_css_set after  subsystems are initialized Zefan Li <lizefan@huawei.com> - 2016-03-03 04:20 +0100
  Re: [cgroup/for-4.6 1/2] cgroup: re-hash init_css_set after  subsystems are initialized Tejun Heo <tj@kernel.org> - 2016-03-03 16:10 +0100

csiph-web