Re: [PATCH] PM: Fix crash on graph trace through x86 suspend

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM: Fix crash on graph trace through x86 suspend
Date	2016-03-03 03:10 +0100
Message-ID	<r8qSd-7S-1@gated-at.bofh.it> (permalink)
References	<r8qpc-89F-13@gated-at.bofh.it> <r8qpc-89F-15@gated-at.bofh.it> <r8qpc-89F-17@gated-at.bofh.it> <r8qpc-89F-11@gated-at.bofh.it> <r8qpd-89F-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 3 Mar 2016 02:36:26 +0100
"Rafael J. Wysocki" <rafael@kernel.org> wrote:

> > OK, applied, but let Steven and the x86 folks see it.

The below patch looks fine to me. Anything else I should look at?

-- Steve

> >  
> >>>  
> >>> > ---
> >>> >  arch/x86/kernel/acpi/sleep.c | 7 +++++++
> >>> >  1 file changed, 7 insertions(+)
> >>> >
> >>> > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> >>> > index d1daead..311360e 100644
> >>> > --- a/arch/x86/kernel/acpi/sleep.c
> >>> > +++ b/arch/x86/kernel/acpi/sleep.c
> >>> > @@ -16,6 +16,7 @@
> >>> >  #include <asm/cacheflush.h>
> >>> >  #include <asm/realmode.h>
> >>> >
> >>> > +#include <linux/ftrace.h>
> >>> >  #include "../../realmode/rm/wakeup.h"
> >>> >  #include "sleep.h"
> >>> >
> >>> > @@ -107,7 +108,13 @@ int x86_acpi_suspend_lowlevel(void)
> >>> >         saved_magic = 0x123456789abcdef0L;
> >>> >  #endif /* CONFIG_64BIT */
> >>> >
> >>> > +       /*
> >>> > +        * Pause/unpause graph tracing around do_suspend_lowlevel as it has
> >>> > +        * inconsistent call/return info after it jumps to the wakeup vector
> >>> > +        */
> >>> > +       pause_graph_tracing();
> >>> >         do_suspend_lowlevel();
> >>> > +       unpause_graph_tracing();
> >>> >         return 0;
> >>> >  }
> >>> >
> >>> > --
> >>> > 2.1.4
> >>> >
> >>> > --  
> >
> >
> > Thanks,
> > Rafael

Thread

Re: [PATCH] PM: Fix crash on graph trace through x86 suspend "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-03 02:40 +0100
  Re: [PATCH] PM: Fix crash on graph trace through x86 suspend "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-03 02:40 +0100
    Re: [PATCH] PM: Fix crash on graph trace through x86 suspend Steven Rostedt <rostedt@goodmis.org> - 2016-03-03 03:10 +0100
      Re: [PATCH] PM: Fix crash on graph trace through x86 suspend "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-03 03:20 +0100

csiph-web