Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348634

Re: [PATCH v4 5/6] dt/bindings: rockchip: modify document of Rockchip power domains

Show all headers | View raw

Elaine Zhang <zhangqing@rock-chips.com> writes:

> Add binding documentation for the power domains
> found on Rockchip RK3399 SoCs
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

For the general approach for adding sub-domains, but some minor nits below...

> ---
>  .../bindings/soc/rockchip/power_domain.txt         | 41 ++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> index 13dc6a3..9eb43fa 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> @@ -7,6 +7,7 @@ Required properties for power domain controller:
>  - compatible: Should be one of the following.
>  	"rockchip,rk3288-power-controller" - for RK3288 SoCs.
>  	"rockchip,rk3368-power-controller" - for RK3368 SoCs.
> +	"rockchip,rk3399-power-controller" - for RK3399 SoCs.
>  - #power-domain-cells: Number of cells in a power-domain specifier.
>  	Should be 1 for multiple PM domains.
>  - #address-cells: Should be 1.
> @@ -16,6 +17,7 @@ Required properties for power domain sub nodes:
>  - reg: index of the power domain, should use macros in:
>  	"include/dt-bindings/power/rk3288-power.h" - for RK3288 type power domain.
>  	"include/dt-bindings/power/rk3368-power.h" - for RK3368 type power domain.
> +	"include/dt-bindings/power/rk3399-power.h" - for RK3399 type power domain.
>  - clocks (optional): phandles to clocks which need to be enabled while power domain
>  	switches state.
>  
> @@ -45,12 +47,45 @@ Example:
>                  };
>          };
>  
> +Example 2:
> +
> +	power: power-controller {
> +		compatible = "rockchip,rk3399-power-controller";
> +		#power-domain-cells = <1>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		/*parent domain*/

please fix up the comment style in these examples (here and below) since they will likely
be copy/pasted into a real DT.

> +		pd_vio {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <RK3399_PD_VIO>;
> +
> +			/*child domain of pd_vio*/
> +			pd_vo {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				reg = <RK3399_PD_VO>;
> +
> +				/*child domain of pd_vo*/
> +				pd_vopb {
> +					reg = <RK3399_PD_VOPB>;
> +				};
> +
> +				pd_vopl {
> +					reg = <RK3399_PD_VOPL>;
> +				};
> +			};
> +		};
> +	};
> +

Kevin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/6] rockchip: power-domain: fix pm domain for support RK3399 SoC Elaine Zhang <zhangqing@rock-chips.com> - 2016-02-26 07:20 +0100
  [PATCH v4 2/6] power-domain: allow domains only handling idle requests Elaine Zhang <zhangqing@rock-chips.com> - 2016-02-26 07:20 +0100
  [PATCH v4 4/6] dt/bindings: power: add RK3399 SoCs header for power-domain Elaine Zhang <zhangqing@rock-chips.com> - 2016-02-26 07:20 +0100
  [PATCH v4 3/6] rockchip: power-domain: add support for sub-power domains Elaine Zhang <zhangqing@rock-chips.com> - 2016-02-26 07:20 +0100
  [PATCH v4 5/6] dt/bindings: rockchip: modify document of Rockchip power domains Elaine Zhang <zhangqing@rock-chips.com> - 2016-02-26 07:30 +0100
    Re: [PATCH v4 5/6] dt/bindings: rockchip: modify document of Rockchip power domains Kevin Hilman <khilman@baylibre.com> - 2016-03-03 01:20 +0100
  [PATCH v4 6/6] rockchip: power-domain: Modify power domain driver for rk3399 Elaine Zhang <zhangqing@rock-chips.com> - 2016-02-26 07:30 +0100

csiph-web