Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1348631

Re: [PATCH v2 3/6] rockchip: power-domain: add support for sub-power domains

From Kevin Hilman <khilman@baylibre.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/6] rockchip: power-domain: add support for sub-power domains
Date 2016-03-03 01:10 +0100
Message-ID <r8p05-7eU-7@gated-at.bofh.it> (permalink)
References <r3srD-2Xh-3@gated-at.bofh.it> <r3srD-2Xh-1@gated-at.bofh.it> <r3H7k-5fY-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Feb 18, 2016 at 4:20 PM, Heiko Stuebner <heiko@sntech.de> wrote:

> In general the code looks like you're going to group the domains
> hirarchically, like
>
>        power: power-controller {
>                compatible = "rockchip,rk3399-power-controller";
>
>                pd_cci {
>                        reg = <RK3399_PD_CCI>;
>                        clocks = ...;
>
>                         pd_cci0 {
>                                 reg = <RK3399_PD_CCI0>;
>                                 clocks = ...;
>                         };
>                };
>        };
>
> This isn't documented in the dt-binding and also isn't really improving
> reading these declarations. Instead as I said before, I think I'd like more
> get inspiration from how Exynos is doing that already

Heiko and I had a chat offline about this, and I mentioned that the
Exynos way is not the preferred way.  The nesting that is being done
here (and in v4) is the better way, and is fully supported by the
genpd code.

Kevin

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2 3/6] rockchip: power-domain: add support for sub-power domains Kevin Hilman <khilman@baylibre.com> - 2016-03-03 01:10 +0100

csiph-web