Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348606
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging/lustre: Unbreak ll_prep_inode iget result check |
| Date | 2016-03-03 00:30 +0100 |
| Message-ID | <r8ono-6Fv-17@gated-at.bofh.it> (permalink) |
| References | <r8f0K-89o-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Mar 02, 2016 at 08:25:39AM -0500, green@linuxhacker.ru wrote:
> From: Oleg Drokin <green@linuxhacker.ru>
>
> commit 020ecc6f3229 ("staging: lustre: llite: Remove IS_ERR tests")
> managed to break one of the converted checks by losing a dereference
> causing the condition to be wrong and hence leading
> to a crash later on in case of actual error.
> IS_ERR_OR_NULL(*inode) got converted into !inode.
>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> CC: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> I am not sure where did that patch came from as I cannot see
> it in either my inbox or in any public mailinglists via google.
My fault, it is part of the Outreachy application process, I missed that
bug, sorry about this.
greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] staging/lustre: Unbreak ll_prep_inode iget result check green@linuxhacker.ru - 2016-03-02 14:30 +0100 Re: [PATCH] staging/lustre: Unbreak ll_prep_inode iget result check Greg KH <gregkh@linuxfoundation.org> - 2016-03-03 00:30 +0100
csiph-web