Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348452
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH RT 3/7] kernel: softirq: unlock with irqs on |
| Date | 2016-03-02 21:20 +0100 |
| Message-ID | <r8lpw-4I9-5@gated-at.bofh.it> (permalink) |
| References | <r8lpv-4I9-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
3.4.110-rt140-rc1 stable review patch. If anyone has any objections, please let me know. ------------------ From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> We unlock the lock while the interrupts are off. This isn't a problem now but will get because the migrate_disable() + enable are not symmetrical in regard to the status of interrupts. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/softirq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index ecf0ab0f7b4d..d2c870a826da 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -561,10 +561,10 @@ static int __thread_do_softirq(int cpu) */ if (local_softirq_pending()) __do_softirq_common(cpu >= 0); - local_unlock(local_softirq_lock); unpin_current_cpu(); - preempt_disable(); local_irq_enable(); + local_unlock(local_softirq_lock); + preempt_disable(); return 0; } -- 2.7.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH RT 3/7] kernel: softirq: unlock with irqs on Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 21:20 +0100
csiph-web