Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348362

Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding

Show all headers | View raw

On Thu, Feb 25, 2016 at 02:03:37PM +0530, Pankaj Dubey wrote:
> This patch adds exynos-srom binding information for SROM Controller
> driver on Exynos SoCs.
> 
> CC: Rob Herring <robh+dt@kernel.org>
> CC: Mark Rutland <mark.rutland@arm.com>
> CC: Ian Campbell <ijc+devicetree@hellion.org.uk>
> CC: devicetree@vger.kernel.org
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Kukjin Kim <kgene@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  .../devicetree/bindings/memory-controllers/exynos-srom.txt   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
> new file mode 100644
> index 0000000..33886d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
> @@ -0,0 +1,12 @@
> +SAMSUNG Exynos SoCs SROM Controller driver.
> +
> +Required properties:
> +- compatible : Should contain "samsung,exynos-srom".

There should be SoC specific compatible strings in addition to this.

> +
> +- reg: offset and length of the register set
> +
> +Example:
> +	sromc@12570000 {

This should be memory-controller@...

> +		compatible = "samsung,exynos-srom";
> +		reg = <0x12570000 0x10>;

The next patch changes the size to 0x14?

BTW, you could just combine both patches. I guess you didn't to maintain 
authorship?

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESPIN 0/6] Add support for Exynos SROM Controller driver. Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-02-25 09:40 +0100
  [RESPIN 5/6] dt-bindings: EXYNOS: Describe SROMc configuration Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-02-25 09:40 +0100
    Re: [RESPIN 5/6] dt-bindings: EXYNOS: Describe SROMc configuration Rob Herring <robh@kernel.org> - 2016-03-02 19:00 +0100
  [RESPIN 3/6] MAINTAINERS: Add maintainers entry for  drivers/memory/samsung Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-02-25 09:40 +0100
  [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-02-25 09:40 +0100
    Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree  binding Rob Herring <robh@kernel.org> - 2016-03-02 19:00 +0100
  [RESPIN 6/6] drivers: memory: exynos-srom: Add support for bank  configuration Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-02-25 09:40 +0100
  Re: [RESPIN 0/6] Add support for Exynos SROM Controller driver. Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-26 09:00 +0100
    RE: [RESPIN 0/6] Add support for Exynos SROM Controller driver. Pavel Fedin <p.fedin@samsung.com> - 2016-02-26 09:40 +0100
      Re: [RESPIN 0/6] Add support for Exynos SROM Controller driver. Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-26 12:00 +0100

csiph-web