Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348240
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH RT 07/13] kernel: softirq: unlock with irqs on |
| Date | 2016-03-02 17:00 +0100 |
| Message-ID | <r8hlW-1fW-65@gated-at.bofh.it> (permalink) |
| References | <r8hce-1c4-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
3.12.54-rt74-rc1 stable review patch. If anyone has any objections, please let me know. ------------------ From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> We unlock the lock while the interrupts are off. This isn't a problem now but will get because the migrate_disable() + enable are not symmetrical in regard to the status of interrupts. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/softirq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index cce9723c5a18..7c8e36bf9e2a 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -578,8 +578,10 @@ static void do_current_softirqs(int need_rcu_bh_qs) do_single_softirq(i, need_rcu_bh_qs); } softirq_clr_runner(i); - unlock_softirq(i); WARN_ON(current->softirq_nestcnt != 1); + local_irq_enable(); + unlock_softirq(i); + local_irq_disable(); } } -- 2.7.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH RT 00/13] Linux 3.12.54-rt74-rc1 Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 17:00 +0100 [PATCH RT 12/13] kernel: sched: Fix preempt_disable_ip recodring for preempt_disable() Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 17:00 +0100 [PATCH RT 01/13] ptrace: dont open IRQs in ptrace_freeze_traced() too early Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 17:00 +0100 [PATCH RT 10/13] trace: Use rcuidle version for preemptoff_hist trace point Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 17:00 +0100 [PATCH RT 07/13] kernel: softirq: unlock with irqs on Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 17:00 +0100 [PATCH RT 05/13] latencyhist: disable jump-labels Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 17:00 +0100 [PATCH RT 11/13] rcu/torture: Comment out rcu_bh ops on PREEMPT_RT_FULL Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 17:00 +0100 [PATCH RT 09/13] sched,rt: __always_inline preemptible_lazy() Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 17:00 +0100 [PATCH RT 14/13] tracing: Fix probe_wakeup_latency_hist_start() prototype Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-03-04 05:10 +0100
csiph-web