Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348165
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH RT 10/20] kernel: softirq: unlock with irqs on |
| Date | 2016-03-02 16:40 +0100 |
| Message-ID | <r8h2z-18n-31@gated-at.bofh.it> (permalink) |
| References | <r8h2y-18n-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
3.18.27-rt27-rc1 stable review patch. If anyone has any objections, please let me know. ------------------ From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> We unlock the lock while the interrupts are off. This isn't a problem now but will get because the migrate_disable() + enable are not symmetrical in regard to the status of interrupts. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/softirq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index a55e80dca611..0b1f914e4639 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -564,8 +564,10 @@ static void do_current_softirqs(int need_rcu_bh_qs) do_single_softirq(i, need_rcu_bh_qs); } softirq_clr_runner(i); - unlock_softirq(i); WARN_ON(current->softirq_nestcnt != 1); + local_irq_enable(); + unlock_softirq(i); + local_irq_disable(); } } -- 2.7.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH RT 10/20] kernel: softirq: unlock with irqs on Steven Rostedt <rostedt@goodmis.org> - 2016-03-02 16:40 +0100
csiph-web