Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348049
| From | Joerg Roedel <joro@8bytes.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch 1/2] iommu/mediatek: signedness bug in probe function |
| Date | 2016-03-02 15:00 +0100 |
| Message-ID | <r8ftO-8on-35@gated-at.bofh.it> (permalink) |
| References | <r8c2R-6eY-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Mar 02, 2016 at 01:10:06PM +0300, Dan Carpenter wrote:
> "larb_nr" needs to be signed for the error handling to work. "i" can
> be int as well.
>
> Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 721ffdb..1a4022c 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
> struct resource *res;
> struct component_match *match = NULL;
> void *protect;
> - unsigned int i, larb_nr;
> + int i, larb_nr;
> int ret;
>
> data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
I merged a similar fix from Andrzej Hajda yesterday.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[patch 1/2] iommu/mediatek: signedness bug in probe function Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-02 11:20 +0100 Re: [patch 1/2] iommu/mediatek: signedness bug in probe function Joerg Roedel <joro@8bytes.org> - 2016-03-02 15:00 +0100
csiph-web