[patch] iommu/exynos: checking for IS_ERR() instead of NULL

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] iommu/exynos: checking for IS_ERR() instead of NULL
Date	2016-03-02 11:20 +0100
Message-ID	<r8c2S-6eY-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

of_platform_device_create() returns NULL on error, it never returns
error pointers.

Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index b066504..cb57bda 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -1347,8 +1347,8 @@ static int __init exynos_iommu_of_setup(struct device_node *np)
 		exynos_iommu_init();
 
 	pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
-	if (IS_ERR(pdev))
-		return PTR_ERR(pdev);
+	if (!pdev)
+		return -ENOMEM;
 
 	/*
 	 * use the first registered sysmmu device for performing

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] iommu/exynos: checking for IS_ERR() instead of NULL Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-02 11:20 +0100
  Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL Marek Szyprowski <m.szyprowski@samsung.com> - 2016-03-02 13:50 +0100
  Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL Joerg Roedel <joro@8bytes.org> - 2016-03-02 16:00 +0100

csiph-web