Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1347902
| From | Juergen Borleis <jbe@pengutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' |
| Date | 2016-03-02 10:50 +0100 |
| Message-ID | <r8bzQ-5NZ-17@gated-at.bofh.it> (permalink) |
| References | <r8bzQ-5NZ-19@gated-at.bofh.it> |
| Organization | Pengutronix e.K. |
Hi Alexandre, On Tuesday 01 March 2016 23:17:45 kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git > rtc-testing head: 58992ebde059d7faeab4c18bc17713c3b4c31208 > commit: 58992ebde059d7faeab4c18bc17713c3b4c31208 [55/55] rtc: pcf85063: > remove useless century handling config: x86_64-randconfig-x012-201609 > (attached as .config) > reproduce: > git checkout 58992ebde059d7faeab4c18bc17713c3b4c31208 > # save the attached .config to linux build tree > make ARCH=x86_64 > > All warnings (new ones prefixed by >>): > > drivers/rtc/rtc-pcf85063.c: In function 'pcf85063_get_datetime': > >> drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' > >> [-Wunused-variable] > > struct pcf85063 *pcf85063 = i2c_get_clientdata(client); > ^ Due to your removement of the useless century handling the last user of 'struct pcf85063' is gone. Seems we can remove this struct entirely. What do you think? Regards, Juergen -- Pengutronix e.K. | Juergen Borleis | Industrial Linux Solutions | http://www.pengutronix.de/ |
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' Juergen Borleis <jbe@pengutronix.de> - 2016-03-02 10:50 +0100 Re: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-02 11:30 +0100
csiph-web